Add container override for images #273
Conversation
| @@ -0,0 +1,26 @@ | |||
| resources: | |||
| - ../../../../gateway | |||
| - envoyproxy.yaml | |||
There was a problem hiding this comment.
just curious why can not we use envoyproxy + gatreway_patch.yaml from the original folder? If we just like to override the images? I think the one under default/kustomization.yaml is good enough?
There was a problem hiding this comment.
There is no envoyproxy + gateway_patch in config/gateway. Its a override added to replace envoyproxy image, which was not needed in US env.
There was a problem hiding this comment.
Got it. Makes sense. I misunderstand this part
| @@ -0,0 +1,4 @@ | |||
| kind: Kustomization | |||
There was a problem hiding this comment.
if we move image override to this folder. does it mean we just need this single file?
There was a problem hiding this comment.
In dependency, envoy-gateway has different namespace. So that will always be separate. In other cases, we can not merge because each one references to their parent also. When I tried to club everything together, resources order is not guaranteed and it was not working.
| @@ -0,0 +1,26 @@ | |||
| resources: | |||
| - ../../../../gateway | |||
| - envoyproxy.yaml | |||
There was a problem hiding this comment.
Got it. Makes sense. I misunderstand this part
* Add container override for images * remove overlays/vke/dependency/kuberay-operator
Address #233