[CI] Github Action trigger condition optimized for cost saving #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwangfw
force-pushed
the
ning/optimize-action-trigger
branch
3 times, most recently
from
6c52467 to
0b3da7b
Compare
Collaborator
Author
|
Let me know if some trigger conditions are not considered or wrongly considered. |
Collaborator
|
can you check |
Jeffwan
reviewed
Nov 20, 2024
.github/workflows/release-build.yaml
Outdated
.github/workflows/python-tests.yml
Outdated
Collaborator
There was a problem hiding this comment.
do we want manual trigger here?
Jeffwan
reviewed
Nov 20, 2024
Collaborator
There was a problem hiding this comment.
we don't push to tags (they are protected). This is something unnecessary I think.
nwangfw
force-pushed
the
ning/optimize-action-trigger
branch
from
0b3da7b to
3c4d13f
Compare
nwangfw
force-pushed
the
ning/optimize-action-trigger
branch
from
3c4d13f to
83b4e14
Compare
Collaborator
Author
tested. |
Jeffwan
approved these changes
Nov 20, 2024
Collaborator
Jeffwan
left a comment
Jeffwan
left a comment
There was a problem hiding this comment.
/lgtm
We have an offline discussion. CI always build new manifest if there's a change merged in. We won't save cost on the post-submit, otherwise, it's hard to track back to the commit if we want to pin version for debug purpose.
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
github action trigger condition optimized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Github Action trigger condition is optimized. Now each test will only be triggered when the corresponding code is modified.
Related Issues
Resolves: #253
Important: Before submitting, please complete the description above and review the checklist below.