Skip to content

Conversation

@zhangjyr
Copy link
Collaborator

Pull Request Description

Request traces are now aggregated in (floor(log2), floor(log2)) buckets, which are too coarse-grained for identifying subtle input-output patterns. This PR introduces:

  1. Meta fields are used for version control for compatibility of later changes (meta_version).
  2. Buckets are now aggregated in finer-grained as (round(log2,1), round(log2,1)). Related meta field: meta_precision.
  3. Sync trace update frequency with trace users, Related meta field: meta_interval_sec.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me

@Jeffwan Jeffwan merged commit c4af8b6 into main Nov 22, 2024
10 checks passed
@Jeffwan Jeffwan deleted the jingyuan/finer_profile_granuality branch November 22, 2024 19:05
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Adjust request trace to finer granularity.
Introduce meta info and version for compatibility

* Make request trace self-explanatory on time interval

---------

Co-authored-by: Jingyuan Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants