Skip to content

Conversation

@nwangfw
Copy link
Collaborator

@nwangfw nwangfw commented Jan 30, 2025

Pull Request Description

This PR adds an example of using external IP rather than port-forwarding to send query to Aibrix in the Quickstart instruction.

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@nwangfw nwangfw changed the title update quickstart tutorial and add example sending requests via gatew… [Doc] update quickstart tutorial and add example sending requests via gatew… Jan 30, 2025
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jeffwan Jeffwan merged commit 882ffee into main Jan 31, 2025
2 checks passed
@Jeffwan Jeffwan deleted the ning/gateway-without-port-forwarding branch January 31, 2025 06:29
@Jeffwan
Copy link
Collaborator

Jeffwan commented Jan 31, 2025

address part of #613

gangmuk pushed a commit to gangmuk/aibrix-gangmuk that referenced this pull request Jun 21, 2025
… gatew… (vllm-project#621)

* update quickstart tutorial and add example sending requests via gateway external ip

* remove last part of ip

Signed-off-by: Ning <[email protected]>

* remove last part of ip (amend)

Signed-off-by: Ning <[email protected]>

---------

Signed-off-by: Ning <[email protected]>
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
… gatew… (vllm-project#621)

* update quickstart tutorial and add example sending requests via gateway external ip

* remove last part of ip

Signed-off-by: Ning <[email protected]>

* remove last part of ip (amend)

Signed-off-by: Ning <[email protected]>

---------

Signed-off-by: Ning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants