Skip to content

Conversation

@happyandslow
Copy link
Collaborator

@happyandslow happyandslow commented Feb 14, 2025

Addressing #666

  • Improving aibrix/benchmarks/generator/client.py with async and streaming mode
  • Supporting the following metrics in the analysis
    • Tokens/s times series plot
    • TTFT times series plot
    • TPOT times series plot
    • Goodput times series plot

Goodput spec (https://github.com/vllm-project/vllm/blob/main/benchmarks/benchmark_serving.py)

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 14, 2025

@happyandslow let's write some description reviewer should be aware of and linked to an issue for future PRs.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 14, 2025

@gangmuk @nwangfw please help review it

@Jeffwan Jeffwan requested review from gangmuk and nwangfw February 14, 2025 18:26
@happyandslow happyandslow changed the title Adding streaming client for AIbrix experiments [WIP] Adding streaming client for AIbrix experiments Feb 17, 2025
@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 18, 2025

@happyandslow can you remove the wip title? is this ready for review?

@happyandslow happyandslow force-pushed the lexu/streaming-client-refactor branch 3 times, most recently from 3758d6c to 5816af6 Compare February 20, 2025 00:20
@happyandslow
Copy link
Collaborator Author

@happyandslow can you remove the wip title? is this ready for review?

Yes

@happyandslow happyandslow changed the title [WIP] Adding streaming client for AIbrix experiments Adding streaming client for AIbrix experiments Feb 20, 2025
Le Xu and others added 9 commits February 21, 2025 11:37
@happyandslow happyandslow force-pushed the lexu/streaming-client-refactor branch from f510d60 to 92ed4db Compare February 21, 2025 19:38
@happyandslow happyandslow merged commit cb91c4e into main Feb 21, 2025
3 checks passed
@happyandslow happyandslow deleted the lexu/streaming-client-refactor branch February 21, 2025 19:40
gangmuk pushed a commit to gangmuk/aibrix-gangmuk that referenced this pull request Jun 21, 2025
* add streaming client initial

Signed-off-by: Le Xu <[email protected]>

* move client to separate directory

Signed-off-by: Le Xu <[email protected]>

* update logging

Signed-off-by: Le Xu <[email protected]>

* update readme

Signed-off-by: Le Xu <[email protected]>

* update analyze script

Signed-off-by: Le Xu <[email protected]>

* add goodput

Signed-off-by: Le Xu <[email protected]>

* clean up

Signed-off-by: Le Xu <[email protected]>

* update with routing strategies

Signed-off-by: Le Xu <[email protected]>

* update user option

Signed-off-by: Le Xu <[email protected]>

---------

Signed-off-by: Le Xu <[email protected]>
Co-authored-by: Le Xu <[email protected]>
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
* add streaming client initial

Signed-off-by: Le Xu <[email protected]>

* move client to separate directory

Signed-off-by: Le Xu <[email protected]>

* update logging

Signed-off-by: Le Xu <[email protected]>

* update readme

Signed-off-by: Le Xu <[email protected]>

* update analyze script

Signed-off-by: Le Xu <[email protected]>

* add goodput

Signed-off-by: Le Xu <[email protected]>

* clean up

Signed-off-by: Le Xu <[email protected]>

* update with routing strategies

Signed-off-by: Le Xu <[email protected]>

* update user option

Signed-off-by: Le Xu <[email protected]>

---------

Signed-off-by: Le Xu <[email protected]>
Co-authored-by: Le Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants