Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Aug 16, 2024

Pull Request Description

Address part of #82

Related Issues

Resolves: #82

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan force-pushed the jiaxin/autoscaling-framework branch from 8e6e79f to 53fb1a0 Compare August 16, 2024 07:32
@Jeffwan Jeffwan force-pushed the jiaxin/autoscaling-framework branch from 40f15a2 to 4a125c2 Compare August 21, 2024 08:20
@Jeffwan Jeffwan changed the title [WIP]: Support kpa/apa autoscaling workflow Support kpa/apa autoscaling workflow part I Aug 21, 2024
@Jeffwan Jeffwan requested a review from kr11 August 21, 2024 08:26
Copy link
Collaborator

@kr11 kr11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of scaler.interfaces looks good to me.

@kr11
Copy link
Collaborator

kr11 commented Aug 22, 2024

LGTM

@kr11 kr11 merged commit c52eb48 into main Aug 22, 2024
@kr11 kr11 deleted the jiaxin/autoscaling-framework branch August 22, 2024 07:11
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Support autoscaling framework

* Refactor the autoscaler framework

* Clean up autoscaler codes

* Fix all linter issues

* Adjust autoscaler interface

* Add license header in new files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor the autoscaling controller to support customized pod autoscaler

3 participants