Skip to content

Conversation

@thomasjpfan
Copy link
Contributor

Pull Request Description

Currently the link from VLLM_ALLOW_RUNTIME_LORA_UPDATING points to a non-existing page. With this PR, it now points to https://docs.vllm.ai/en/stable/features/lora.html#dynamically-serving-lora-adapters

Related Issues

None

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 19, 2025

@thomasjpfan thanks for the update. could you sign off the commit to pass DCO check?

@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 21, 2025

I will merge this one and please remember to sign off commits next time

@Jeffwan Jeffwan merged commit 4dd92f2 into vllm-project:main Mar 21, 2025
2 of 3 checks passed
gangmuk pushed a commit to gangmuk/aibrix-gangmuk that referenced this pull request Jun 21, 2025
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants