[Misc] chore(raycluster): add concurrency limit and error aggregation to scaleDown #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leDown Signed-off-by: googs1025 <[email protected]>
Jeffwan
approved these changes
Mar 28, 2025
Collaborator
Jeffwan
left a comment
Jeffwan
left a comment
There was a problem hiding this comment.
/lgtm
thanks for the contribution!
| // aggregate errors if any. | ||
| var aggregatedErrors []error | ||
| for err := range errCh { | ||
| aggregatedErrors = append(aggregatedErrors, err) |
Collaborator
There was a problem hiding this comment.
using aggregated errors looks good to me.
| errCh := make(chan error, diff) | ||
| // limit the number of concurrent deletions goroutine. | ||
| // todo: make this configurable? | ||
| const maxConcurrency = 10 |
Collaborator
There was a problem hiding this comment.
it's ok to have a fixed value at this moment
gangmuk
pushed a commit
to gangmuk/aibrix-gangmuk
that referenced
this pull request
Jun 21, 2025
… to scaleDown (vllm-project#914) chore(raycluster): add concurrency limit and error aggregation to scaleDown Signed-off-by: googs1025 <[email protected]>
Yaegaki1Erika
pushed a commit
to Yaegaki1Erika/aibrix
that referenced
this pull request
Jul 23, 2025
… to scaleDown (vllm-project#914) chore(raycluster): add concurrency limit and error aggregation to scaleDown Signed-off-by: googs1025 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[Please provide a clear and concise description of your changes here]
This PR improves the
scaleDown:Related Issues
Resolves: #[Insert issue number(s)] None
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.