Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Apr 11, 2025

Pull Request Description

Refactor kv cache controller to support different setup modes

  1. centralized - vineyard
  2. distributed - individual cache server (prisDB/infinistore) + consistency hashing

Related Issues

Resolves: Phase I of #948, the distributed part will be in separate PR

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Apr 11, 2025

image
Just fix those issues

@Jeffwan Jeffwan requested review from DwyaneShi and varungup90 April 11, 2025 20:41
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Apr 11, 2025

image

there're still flaky tests

Copy link
Collaborator

@varungup90 varungup90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jeffwan Jeffwan merged commit f446ea1 into vllm-project:main Apr 11, 2025
15 of 16 checks passed
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
…roject#971)

* Refactor kv cache controller to support different setup modes
* Make metadata server etcd/redis optional
* Resolve the linter errors
* Fix the metadata compatibility issues

Signed-off-by: Jiaxin Shan <[email protected]>

---------

Signed-off-by: Jiaxin Shan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants