Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Apr 21, 2025

Pull Request Description

Support HPKV orchestration.

Related Issues

Resolves: part of #928 #948

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan changed the title Support hpkv in kv cache controller [WIP] Support hpkv in kv cache controller Apr 21, 2025
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Apr 21, 2025

Please do not review this PR. it's still in progress and I will add more test coverage and finish e2e testing

@Jeffwan Jeffwan force-pushed the jiaxin/support-hpkv branch from 9decb2f to 1ab8d2b Compare April 21, 2025 04:16
@Jeffwan Jeffwan force-pushed the jiaxin/support-hpkv branch from 1ab8d2b to 08ccc56 Compare April 21, 2025 04:20
@Jeffwan Jeffwan requested a review from Copilot April 21, 2025 04:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for HPKV orchestration by introducing new annotation constants and configuration parameters used in distributed mode.

  • Adds new annotation constants for RDMA port, admin port, block size, block count, total slots, and virtual node count.
  • Introduces a ClusterParams struct and helper functions (getPortAnnotation and getPositiveIntAnnotation) to parse these annotations.
  • Updates the environment variables and container command configurations in both the watcher pod and cache statefulset for HPKV support.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
pkg/controller/kvcache/kvcache_controller.go Added new annotation constants for HPKV orchestration.
pkg/controller/kvcache/distributed.go Introduced ClusterParams, updated pod env vars and command formatting to support HPKV orchestration.
Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

pkg/controller/kvcache/distributed.go:254

  • [nitpick] Consider confirming if the change from using kvCache.ObjectMeta.UID to kvCache.UID is intentional; using ObjectMeta.UID may improve clarity since it explicitly refers to the metadata object's UID.
metadataEnvVars := []corev1.EnvVar{

@Jeffwan Jeffwan force-pushed the jiaxin/support-hpkv branch from b6b06ab to 34522fc Compare April 21, 2025 04:56
Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan force-pushed the jiaxin/support-hpkv branch from 09da158 to fc380b8 Compare April 21, 2025 06:18
@Jeffwan Jeffwan changed the title [WIP] Support hpkv in kv cache controller Support hpkv in kv cache controller Apr 22, 2025
Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan requested a review from DwyaneShi April 22, 2025 22:03
Copy link
Collaborator

@DwyaneShi DwyaneShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and approved

@Jeffwan Jeffwan merged commit 7e5caa7 into vllm-project:main Apr 22, 2025
11 checks passed
@Jeffwan Jeffwan deleted the jiaxin/support-hpkv branch April 22, 2025 22:57
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants