-
Notifications
You must be signed in to change notification settings - Fork 501
Support hpkv in kv cache controller #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please do not review this PR. it's still in progress and I will add more test coverage and finish e2e testing |
9decb2f to
1ab8d2b
Compare
Signed-off-by: Jiaxin Shan <[email protected]>
1ab8d2b to
08ccc56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for HPKV orchestration by introducing new annotation constants and configuration parameters used in distributed mode.
- Adds new annotation constants for RDMA port, admin port, block size, block count, total slots, and virtual node count.
- Introduces a ClusterParams struct and helper functions (getPortAnnotation and getPositiveIntAnnotation) to parse these annotations.
- Updates the environment variables and container command configurations in both the watcher pod and cache statefulset for HPKV support.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/controller/kvcache/kvcache_controller.go | Added new annotation constants for HPKV orchestration. |
| pkg/controller/kvcache/distributed.go | Introduced ClusterParams, updated pod env vars and command formatting to support HPKV orchestration. |
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
pkg/controller/kvcache/distributed.go:254
- [nitpick] Consider confirming if the change from using kvCache.ObjectMeta.UID to kvCache.UID is intentional; using ObjectMeta.UID may improve clarity since it explicitly refers to the metadata object's UID.
metadataEnvVars := []corev1.EnvVar{
Signed-off-by: Jiaxin Shan <[email protected]>
b6b06ab to
34522fc
Compare
Signed-off-by: Jiaxin Shan <[email protected]>
09da158 to
fc380b8
Compare
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
DwyaneShi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and approved
Signed-off-by: Jiaxin Shan <[email protected]>
Pull Request Description
Support HPKV orchestration.
Related Issues
Resolves: part of #928 #948
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.