-
Notifications
You must be signed in to change notification settings - Fork 17
Deprecate sendnn_decoder in favor of sendnn with warmup_mode #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to vLLM support on Spyre.
Or this can be done with
Now you are good to go 🚀 |
ae46c4a
to
e0bf459
Compare
| Decoder | v0 | sendnn_decoder | V0 support for decoder models is deprecated | | ||
| Decoder | v1 | sendnn_decoder | | | ||
| Decoder | v0 | sendnn | V0 support for decoder models is deprecated | | ||
| Decoder | v1 | sendnn | | | ||
| Embedding | v0 | sendnn | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may have been mistaken when I wrote this and we actually need the sendnn_decoder
backend for v0 embeddings. At least I think it looks like that's how our internal CI is set up to run them right now.
Would be good to double check that, though hopefully we deprecate soon anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, my understanding is that decoder models can be used for embeddings as well (typically via "pooling").
I'm not following what needs to be checked. This PR is removing use of the sendnn_decoder
backend (with a fallback to sendnn), so all embedding models would use sendnn
.
bot:test |
2 similar comments
bot:test |
bot:test |
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
Signed-off-by: Travis Johnson <[email protected]>
e0bf459
to
a842288
Compare
bot:test |
A few internal CI tests are failing, but the same tests pass for me in my dev environment. |
I had to fix the internal automation, but I did see my last test run pass 🤔. Can't hurt to try again! |
bot:test |
bot:test |
4 similar comments
bot:test |
bot:test |
bot:test |
bot:test |
If
TORCH_SENDNN_LOG
is set to WARNING instead of CRITICAL, there are logs statingThis PR makes the change to sendnn. For backwards compatibility, sendnn_decoder is overwritten to sendnn and a warning is logged.