-
Notifications
You must be signed in to change notification settings - Fork 17
Clean up examples and PR template #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
👋 Hi! Thank you for contributing to vLLM support on Spyre.
Or this can be done with
Now you are good to go 🚀 |
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes might have a major conflict on the change that Sophie is making in this PR - #228
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are compatible 👍but you will probably need to handle a couple of conflicts
Apart from the upcoming conflict, I love the changes! I can wait for both of you to coordinate with each other to see who will pick up whose changes before approving this PR |
it's good to see these simplifications Question: should the notebooks (.ipynb) files also be moved to Otherwise LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are compatible 👍but you will probably need to handle a couple of conflicts
Signed-off-by: Rafael Vasquez <[email protected]>
I think so! Or maybe a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.github/
to be seen