Skip to content

[CB] remove VLLM_SPYRE_RM_PADDED_BLOCKS, enable the feature by default #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2025

Conversation

yannicks1
Copy link
Collaborator

[CB] remove VLLM_SPYRE_RM_PADDED_BLOCKS, enable the feature by default

This PR removes VLLM_SPYRE_RM_PADDED_BLOCKS and enables the removal of padded blocks by default. The feature is working on AIU Spyre, hence there is no need for turning it off anymore.

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Signed-off-by: Yannick Schnider <[email protected]>
@yannicks1 yannicks1 marked this pull request as ready for review June 12, 2025 17:43
Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love negative diff

Copy link
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some nits

@@ -203,7 +202,7 @@ def get_params_test_blocks_borders_aligned_prompts():
},
{
"step": 70, # Decode sequence 2
"tkv": 131,
"tkv": 67,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a comment on why the tkv decreased since left padding reduction is default now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if get_params_test_remove_left_padding still has any value left since removing the left padding is the default cc @sducouedic

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, do you agree @sducouedic ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep we should remove that one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep we should remove that one

@yannicks1 yannicks1 merged commit 11562e9 into main Jun 13, 2025
20 checks passed
@yannicks1 yannicks1 deleted the ysc-enable-padding-optimization-permanently branch June 13, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants