Skip to content

Exclude vllm v0.9.1 as an allowed version due to breaking bug #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

tjohnson31415
Copy link
Collaborator

vLLM v0.9.1 contains a bug that causes vllm-spyre to hang on boot-up.

The bug is not respecting num_gpu_blocks_overrides. It was introduced in vllm-project/vllm#17996 and fixed in vllm-project/vllm#19503.

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Some great context from Joe - #213 (comment)

Signed-off-by: Travis Johnson <[email protected]>
@joerunde joerunde merged commit e5306fe into main Jun 13, 2025
20 checks passed
@joerunde joerunde deleted the exclude-vllm-release branch June 13, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants