Skip to content

🥅 disable v0 decoders #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

🥅 disable v0 decoders #242

merged 3 commits into from
Jun 18, 2025

Conversation

joerunde
Copy link
Collaborator

@joerunde joerunde commented Jun 18, 2025

Description

This updates our platform.py to disable v0 for generation, since it will be no longer supported in fms 1.1.0

Related to #241

Unfortunately the entire v0 stack needs to remain in place for embeddings models, which require the v0 scheduler, v0 worker, and v0 embeddings model runner (which is a child of the v0 decoder model runner)

Signed-off-by: Joe Runde <[email protected]>
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@joerunde joerunde enabled auto-merge (squash) June 18, 2025 20:25
@github-actions github-actions bot added the ready label Jun 18, 2025
Copy link
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joerunde joerunde merged commit c00da14 into main Jun 18, 2025
19 checks passed
@joerunde joerunde deleted the remove-v0 branch June 18, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants