Skip to content

[Misc] Update compressed-tensors WNA16 to support zero-points #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 15, 2025
Merged

[Misc] Update compressed-tensors WNA16 to support zero-points #14211

merged 15 commits into from
Apr 15, 2025

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Mar 4, 2025 •
edited by github-actions bot
Loading

Summary

  • Update compressed-tensors WNA16 to support azp
  • Update kernel selection logic to consider models with zp - by @ElizaWszola
  • Required for compressed-tensors AWQ support

Testing Models:

  • GPTQ: TinyLlama-1.1B-Chat-v1.0-W4A16-G128-Asym-Updated-Channel
  • GPTQ: TinyLlama-1.1B-Chat-v1.0-W4A16-G128-Asym-Updated
  • AWQ: nm-testing/TinyLlama-1.1B-Chat-v1.0-awq-group128-asym256
  • Tested with tp=1,2
  • GPTQ + Act Order: nm-testing/TinyLlama-1.1B-Chat-v1.0-W4A16-G128-Asym-Updated-ActOrder (fails with TP>1)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@dsikka dsikka changed the title [Misc [Misc] Update compressed-tensors WNA16 to support zero-points Mar 4, 2025
@dsikka dsikka marked this pull request as draft March 4, 2025 14:17
@mergify Mergify
Copy link

mergify bot commented Apr 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @dsikka.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@dsikka dsikka marked this pull request as ready for review April 10, 2025 15:52
@dsikka dsikka marked this pull request as draft April 10, 2025 16:34
mgoin
mgoin reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clean and good to me, could you add an e2e/lm-eval test?

@dsikka dsikka marked this pull request as ready for review April 14, 2025 16:33
brian-dellabetta
brian-dellabetta approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a TODO comment about a more efficient implementation, but we will tackle that at a later date?

dsikka added 2 commits April 14, 2025 23:19
@dsikka
fix tets
c429535 
Signed-off-by: Dipika Sikka <[email protected]>
@dsikka
remove extra condition
e90276a 
Signed-off-by: Dipika Sikka <[email protected]>
@dsikka
Copy link
Contributor Author

dsikka commented Apr 15, 2025

There is a TODO comment about a more efficient implementation, but we will tackle that at a later date?

Do you mind leaving a comment where you see?

dsikka and others added 2 commits April 15, 2025 00:52
@dsikka
swap order
43d8143 
Signed-off-by: Dipika Sikka <[email protected]>
@mgoin
Format
485d1e9 
Signed-off-by: mgoin <[email protected]>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 15, 2025
dsikka and others added 2 commits April 15, 2025 03:29
@dsikka
fix test value
3b12a0a 
Signed-off-by: Dipika Sikka <[email protected]>
@ElizaWszola
Remove todo
4fe26f6 
Signed-off-by: ElizaWszola <[email protected]>
@ElizaWszola
Copy link
Contributor

There is a TODO comment about a more efficient implementation, but we will tackle that at a later date?

@brian-dellabetta @dsikka I think it's good enough, it ended up similar to what we do in some other parts of the code. I removed the TODO.

@mgoin mgoin merged commit 54a66e5 into vllm-project:main Apr 15, 2025
44 of 45 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@dsikka @yangw-dev
[Misc] Update compressed-tensors WNA16 to support zero-points (vllm…
293b6e5 
…-project#14211)

Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@dsikka @dbyoung18
[Misc] Update compressed-tensors WNA16 to support zero-points (vllm…
e628ffc 
…-project#14211)
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@dsikka @lk-chen
[Misc] Update compressed-tensors WNA16 to support zero-points (vllm…
10f9aa1 
…-project#14211)
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@dsikka
[Misc] Update compressed-tensors WNA16 to support zero-points (vllm…
acc386c 
…-project#14211)

Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
@dsikka dsikka deleted the update_ct_wna16 branch May 15, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

Assignees
No one assigned
Labels
quantization ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsikka @ElizaWszola @mgoin @brian-dellabetta