Skip to content

[MISC] rename interval to max_recent_requests #14285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2025
Merged

[MISC] rename interval to max_recent_requests #14285

merged 2 commits into from
Apr 26, 2025

Conversation

andyxning
Copy link
Contributor

@andyxning andyxning commented Mar 5, 2025 •
edited by github-actions bot
Loading

rename interval to max_recent_requests to make the code more readable.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 5, 2025
comaniac
comaniac reviewed Mar 5, 2025
View reviewed changes
vllm/v1/core/kv_cache_utils.py Outdated
@@ -34,12 +34,12 @@ class PrefixCachingMetrics:
"""Metrics for prefix caching with a hit rate of the most recent N requests.

Args:
interval: The number of the most recent requests to aggregate.
max_recent_queries: The number of the most recent requests to aggregate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually "max_recent_requests". We might also need to correct the document...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. PTAL.

@andyxning andyxning force-pushed the rename_interval_to_max_recent_queries branch 2 times, most recently from 5e776b2 to d3cd504 Compare March 6, 2025 02:16
@andyxning andyxning force-pushed the rename_interval_to_max_recent_queries branch from d3cd504 to 4bff1eb Compare March 6, 2025 02:17
@andyxning andyxning changed the title [MISC] rename interval to max_recent_queries [MISC] rename interval to max_recent_requests Mar 6, 2025
@comaniac comaniac enabled auto-merge (squash) March 6, 2025 02:26
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 6, 2025
@DarkLight1337
Copy link
Member

Can you merge from main to try to resolve the CI failures?

@DarkLight1337
Copy link
Member

Entrypoints tests are failing consistently, PTAL

@comaniac comaniac merged commit fd11a32 into vllm-project:main Apr 26, 2025
42 checks passed
@andyxning andyxning deleted the rename_interval_to_max_recent_queries branch April 27, 2025 02:00
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@andyxning @dbyoung18
[MISC] rename interval to max_recent_requests (vllm-project#14285)
c655d5b
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@andyxning @lk-chen
[MISC] rename interval to max_recent_requests (vllm-project#14285)
d12ce9c
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@andyxning @adobrzyn
[MISC] rename interval to max_recent_requests (vllm-project#14285)
96b91a0 
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@andyxning
[MISC] rename interval to max_recent_requests (vllm-project#14285)
9173baa 
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@andyxning
[MISC] rename interval to max_recent_requests (vllm-project#14285)
6b176ca 
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@andyxning @minpeter
[MISC] rename interval to max_recent_requests (vllm-project#14285)
899fb0c 
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyxning @DarkLight1337 @comaniac