-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Kernel] Remove redundant Exp calculations #16123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] Remove redundant Exp calculations #16123
Conversation
Signed-off-by: DefTruth <[email protected]>
Signed-off-by: DefTruth <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
@LucasWilkinson PTAL, thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
@LucasWilkinson some tests failed, but it seems not related to this PR. |
weird, i don't why the mamba kernel tests failed FAILED kernels/test_mamba_ssm_ssd.py::test_mamba_chunk_scan_cont_batch[seq_len_chunk_size_cases0-5-8-itype0]
AssertionError: chunk_indices and chunk_offsets should have been set |
The mamba ssd kernel test failed, related PR #16623 |
Signed-off-by: DefTruth <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: DefTruth <[email protected]>
Signed-off-by: DefTruth <[email protected]>
Signed-off-by: DefTruth <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Remove redundant Exp calculations