-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Core][Bugfix] Fix Offline MM Beam Search #16390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][Bugfix] Fix Offline MM Beam Search #16390
Conversation
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a simple test similar to tests/samplers/test_beam_search.py
?
Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
6e54658
to
87a7172
Compare
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
prompts = [TextPrompt(prompt=prompt) for prompt in prompts] | ||
else: | ||
prompts = [ | ||
TokensPrompt(prompt_token_ids=tokens) for tokens in prompts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we currently don't use this, so removed it for now to keep things nice looking and consistent the other helpers / get_inputs
. Happy to put it back later on if it ends up being needed though
Signed-off-by: Alex-Brooks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this should be good assuming that the tests pass
Awesome, thanks a lot for the fast reviews Cyrus! 😄 |
Looks like it failed in the CI, I'll try to fix it later today 🤞 |
Signed-off-by: Alex-Brooks <[email protected]>
Head branch was pushed to by a user without write access
Hey @DarkLight1337, things are passing now (reduced beams to |
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Fixes passing the multimodal data for offline beam search.
FIX #16240
FIX #15694
Snippet to verify:
Now considers the mm data in the beam search result.
CC @DarkLight1337 🙂