Skip to content

[CI] Cleanup additional_dependencies: [toml] for pre-commit yapf hook #16405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Apr 10, 2025

In https://github.com/vllm-project/vllm/blob/main/.pre-commit-config.yaml , there is a TODO note: "Remove when yapf is upgraded."

This PR #12475 , yapf was upgraded from v0.32.0 to v0.43.0. According to yapf's changelog, starting from v0.40.2, toml is now included by default in additional_dependencies, making explicit declaration unnecessary.

This cleanup removes the redundant configuration.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yankay yankay changed the title [CI] Cleanup additional_dependencies: [toml] for pre-commit yapf hook [CI] Cleanup additional_dependencies: [toml] for pre-commit yapf hook Apr 10, 2025
@yankay yankay force-pushed the cleanup-yapf-pre-commit-todo branch from d7f2b6e to 00c372f Compare April 10, 2025 10:56
@yankay
Copy link
Contributor Author

yankay commented Apr 11, 2025

HI @mgoin @hmellor

Would you please help to review it :-)

@hmellor
Copy link
Member

hmellor commented Apr 11, 2025

Can you verify that this still works when pre-commit is used in a Python 3.9 environment? That's my only concern

@yankay
Copy link
Contributor Author

yankay commented Apr 16, 2025

Can you verify that this still works when pre-commit is used in a Python 3.9 environment? That's my only concern

HI @hmellor

It can be run in the Python 3.9, screen shoot:

img_v3_02ld_2a6d1da8-5b92-48cc-9451-06815003bbcg

@hmellor hmellor enabled auto-merge (squash) April 16, 2025 09:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 16, 2025
@hmellor hmellor merged commit 21378a2 into vllm-project:main Apr 16, 2025
40 checks passed
lionelvillard pushed a commit to lionelvillard/vllm that referenced this pull request Apr 17, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants