-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[CI] Cleanup additional_dependencies: [toml]
for pre-commit yapf hook
#16405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Cleanup additional_dependencies: [toml]
for pre-commit yapf hook
#16405
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
additional_dependencies: [toml]
for pre-commit yapf hook
Signed-off-by: Kay Yan <[email protected]>
d7f2b6e
to
00c372f
Compare
Can you verify that this still works when |
HI @hmellor It can be run in the Python 3.9, screen shoot: |
…ok (vllm-project#16405) Signed-off-by: Kay Yan <[email protected]>
…ok (vllm-project#16405) Signed-off-by: Kay Yan <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…ok (vllm-project#16405) Signed-off-by: Kay Yan <[email protected]>
…ok (vllm-project#16405) Signed-off-by: Kay Yan <[email protected]>
…ok (vllm-project#16405) Signed-off-by: Kay Yan <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…ok (vllm-project#16405) Signed-off-by: Kay Yan <[email protected]> Signed-off-by: Mu Huai <[email protected]>
In https://github.com/vllm-project/vllm/blob/main/.pre-commit-config.yaml , there is a TODO note: "Remove when yapf is upgraded."
This PR #12475 , yapf was upgraded from v0.32.0 to v0.43.0. According to yapf's changelog, starting from v0.40.2, toml is now included by default in additional_dependencies, making explicit declaration unnecessary.
This cleanup removes the redundant configuration.