-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[V1][Misc] stop update prefix cache stats when logs_stats is disabled #16460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: vie-serendipity <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: vie-serendipity <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Could you add a simple unit test to metrics?
@@ -39,8 +39,8 @@ def __init__( | |||
|
|||
self.enable_caching = enable_caching | |||
self.caching_hash_fn = sha256 if caching_hash_algo == "sha256" else hash | |||
# FIXME: make prefix cache stats conditional on log_stats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need this comment because when the log stats is enabled there are still potential configs we could expose in the future.
@comaniac Sure. |
Signed-off-by: vie-serendipity <[email protected]>
a5842d0
to
8a6a3f8
Compare
@comaniac PTAL |
…vllm-project#16460) Signed-off-by: vie-serendipity <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…vllm-project#16460) Signed-off-by: vie-serendipity <[email protected]>
…vllm-project#16460) Signed-off-by: vie-serendipity <[email protected]>
…vllm-project#16460) Signed-off-by: vie-serendipity <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…vllm-project#16460) Signed-off-by: vie-serendipity <[email protected]> Signed-off-by: Mu Huai <[email protected]>
When log stats are disabled, the prefix_cache_stats does not need to be initialized or updated.
vllm/vllm/v1/core/kv_cache_manager.py
Line 42 in 905e91e