-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add vllm bench [latency, throughput]
CLI commands
#16508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vllm bench [latency, throughput]
CLI commands
#16508
Conversation
Signed-off-by: mgoin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: mgoin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this PR mostly copies the code from benchmarks I mainly reviewed the dependencies and scope. Overall LGTM.
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Was able to fully move
benchmarks/benchmark_latency.py
andbenchmarks/benchmark_throughput.py
intovllm bench latency
andvllm bench throughput
commands, respectively. I also added tests for all threelatency/serve/throughput
commands. In a followup PR I will move more functionality intoserve
that was left behind. We can also remove some of the utility files inbenchmarks/
as they will be in the vllm package now. This should wait for a few vLLM releases imoTested manually and with CI smoke tests added: