Skip to content

[BugFix]: Update minimum pyzmq version #16549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

[BugFix]: Update minimum pyzmq version #16549

merged 2 commits into from
Apr 15, 2025

Conversation

taneem-ibrahim
Copy link
Contributor

@taneem-ibrahim taneem-ibrahim commented Apr 13, 2025 •
edited by github-actions bot
Loading

FIX #15121

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 13, 2025
@taneem-ibrahim
Fixed issue vllm-project#15121: TypeError: an integer is required by …
dd2d304 
…bumping the pyzmq >= 25.0.0

Signed-off-by: Taneem Ibrahim <[email protected]>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 13, 2025
@njhill njhill changed the title Fixed issue #15121: TypeError: an integer is required by bumping the … [BugFix]: Update minimum pyzmq version Apr 15, 2025
njhill
njhill approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taneem-ibrahim!

@vllm-bot vllm-bot merged commit 70e7ed8 into vllm-project:main Apr 15, 2025
62 of 69 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@taneem-ibrahim @mgoin @yangw-dev
[BugFix]: Update minimum pyzmq version (vllm-project#16549)
1e24f7d 
Signed-off-by: Taneem Ibrahim <[email protected]>
Co-authored-by: mgoin <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@keety keety mentioned this pull request Apr 22, 2025
Closed
1 task
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@taneem-ibrahim @mgoin @dbyoung18
[BugFix]: Update minimum pyzmq version (vllm-project#16549)
9cc1386 
Signed-off-by: Taneem Ibrahim <[email protected]>
Co-authored-by: mgoin <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@taneem-ibrahim @mgoin @lk-chen
[BugFix]: Update minimum pyzmq version (vllm-project#16549)
92e755f 
Signed-off-by: Taneem Ibrahim <[email protected]>
Co-authored-by: mgoin <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@taneem-ibrahim @mgoin
[BugFix]: Update minimum pyzmq version (vllm-project#16549)
f263f23 
Signed-off-by: Taneem Ibrahim <[email protected]>
Co-authored-by: mgoin <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhill njhill njhill approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [V1] AWQ, GPTQ fail to start due to TypeError: an integer is required
4 participants
@taneem-ibrahim @njhill @mgoin @vllm-bot