Skip to content

[Misc] remove warning if triton>=3.2.0 #16553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

[Misc] remove warning if triton>=3.2.0 #16553

merged 2 commits into from
Apr 14, 2025

Conversation

DefTruth
Copy link
Contributor

@DefTruth DefTruth commented Apr 13, 2025 •
edited by github-actions bot
Loading

Remove warning if triton>=3.2.0, since now triton are already >= 3.2.0

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

houseroad
houseroad reviewed Apr 14, 2025
View reviewed changes
vllm/attention/ops/triton_decode_attention.py Outdated
@@ -39,11 +39,12 @@

logger = logging.getLogger(__name__)

# TODO: Remove this when triton>=3.2.0. This issue will not affect performance
# Remove this warning when triton>=3.2.0. This issue will not affect performance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about: "only print the following warnings when triton version < 3.2.0. The issue won't affect performance or accuracy."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

houseroad
houseroad approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 14, 2025
@vllm-bot vllm-bot merged commit ce4ddd2 into vllm-project:main Apr 14, 2025
52 of 61 checks passed
@DefTruth DefTruth deleted the remove-triton-warn branch April 15, 2025 15:46
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@DefTruth @yangw-dev
[Misc] remove warning if triton>=3.2.0 (vllm-project#16553)
e0af6aa 
Signed-off-by: DefTruth <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@DefTruth @dbyoung18
[Misc] remove warning if triton>=3.2.0 (vllm-project#16553)
31e51ad 
Signed-off-by: DefTruth <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DefTruth @lk-chen
[Misc] remove warning if triton>=3.2.0 (vllm-project#16553)
bc457e1 
Signed-off-by: DefTruth <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DefTruth
[Misc] remove warning if triton>=3.2.0 (vllm-project#16553)
7027651 
Signed-off-by: DefTruth <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DefTruth @houseroad @vllm-bot