Skip to content

[Bugfix] Multi-modal caches not acting like LRU caches #16593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2025
Merged

[Bugfix] Multi-modal caches not acting like LRU caches #16593

merged 4 commits into from
Apr 14, 2025
+187 −126

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 14, 2025 •
edited by github-actions bot
Loading

LRUCache is not updated by __contains__. So, we should call get directly.

Also, fix __getitem__ not updating cache stats

FIX #16273 (comment)

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 14, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py April 14, 2025 13:22
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Apr 14, 2025
Open
@mergify mergify bot added the v1 label Apr 14, 2025
@DarkLight1337 DarkLight1337 mentioned this pull request Apr 14, 2025
Merged
@DarkLight1337
Update cache and tests
8420d58 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Try fix pre-commit
8108c36 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 mentioned this pull request Apr 14, 2025
Closed
@DarkLight1337
Fix
931d094 
Signed-off-by: DarkLight1337 <[email protected]>
@vllm-bot vllm-bot merged commit aa29841 into vllm-project:main Apr 14, 2025
39 of 47 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-mm-cache branch April 14, 2025 16:24
@DarkLight1337 DarkLight1337 mentioned this pull request Apr 19, 2025
Closed
1 task
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@DarkLight1337 @yangw-dev
[Bugfix] Multi-modal caches not acting like LRU caches (vllm-project#…
9faf3e0 
…16593)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @dbyoung18
[Bugfix] Multi-modal caches not acting like LRU caches (vllm-project#…
31d9540 
…16593)

Signed-off-by: DarkLight1337 <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] Multi-modal caches not acting like LRU caches (vllm-project#…
5cf9b53 
…16593)

Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 mentioned this pull request May 8, 2025
Closed
1 task
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Multi-modal caches not acting like LRU caches (vllm-project#…
663af85 
…16593)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
@DarkLight1337 DarkLight1337 mentioned this pull request Jun 28, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @Isotr0py @vllm-bot