Skip to content

Fix triton install condition on CPU #16600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fix triton install condition on CPU #16600

merged 1 commit into from
Apr 14, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 14, 2025

Issues were also seen when trying to install on Mac.

This PR inverts the condition to make it so that triton is only installed for x86 CPUs.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 14, 2025
@Isotr0py
Copy link
Collaborator

IIRC, triton is never used by CPU backend. Not sure why it's introduced in cpu.txt TBH. 🤔

@hmellor
Copy link
Member Author

hmellor commented Apr 14, 2025

More context is here #16413

@Isotr0py
Copy link
Collaborator

Hmmm, anyway, let's merge this PR to fix arm CPU installation.

@Isotr0py Isotr0py enabled auto-merge (squash) April 14, 2025 16:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 14, 2025
@Isotr0py Isotr0py merged commit 9883a18 into vllm-project:main Apr 14, 2025
40 of 42 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@hmellor @yangw-dev
Fix triton install condition on CPU (vllm-project#16600)
5decf0c 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@hmellor hmellor deleted the fix-cpu-install branch April 24, 2025 16:22
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@hmellor @dbyoung18
Fix triton install condition on CPU (vllm-project#16600)
a1a28cf 
Signed-off-by: Harry Mellor <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @lk-chen
Fix triton install condition on CPU (vllm-project#16600)
1e80eb4 
Signed-off-by: Harry Mellor <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Fix triton install condition on CPU (vllm-project#16600)
22c7388 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@Isotr0py Isotr0py Isotr0py approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmellor @Isotr0py @jeejeelee