-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Hardware] Add processor inputs to platform validation #16680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joe Runde <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, benchmark is running fine on TPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joerunde
…16680) Signed-off-by: Joe Runde <[email protected]>
…16680) Signed-off-by: Joe Runde <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…16680) Signed-off-by: Joe Runde <[email protected]>
…16680) Signed-off-by: Joe Runde <[email protected]>
…16680) Signed-off-by: Joe Runde <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…16680) Signed-off-by: Joe Runde <[email protected]> Signed-off-by: Mu Huai <[email protected]>
A followup to #16291
This moves the
current_platform.validate_request
call to after input preprocessing happens, so that theProcessorInputs
can also be passed to the platform. This will ensure the platform plugins have access to the tokenized prompt and multimodal data for validation as well.This is a slightly api breaking change since implementations that don't accept the
processed_inputs
kwarg would break, but I've updated the tpu implementation here and vllm-ascend hasn't implemented it yet.I'll wait for @NickLucche to test this on TPU this time before merging to make sure I didn't break it again