Skip to content

[Hardware] Add processor inputs to platform validation #16680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

joerunde
Copy link
Collaborator

@joerunde joerunde commented Apr 15, 2025

A followup to #16291

This moves the current_platform.validate_request call to after input preprocessing happens, so that the ProcessorInputs can also be passed to the platform. This will ensure the platform plugins have access to the tokenized prompt and multimodal data for validation as well.

This is a slightly api breaking change since implementations that don't accept the processed_inputs kwarg would break, but I've updated the tpu implementation here and vllm-ascend hasn't implemented it yet.

I'll wait for @NickLucche to test this on TPU this time before merging to make sure I didn't break it again

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@joerunde joerunde changed the title ♻️ Add processor inputs to platform validation [Hardware] Add processor inputs to platform validation Apr 15, 2025
@mergify mergify bot added v1 tpu Related to Google TPUs labels Apr 15, 2025
@joerunde joerunde added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 15, 2025
Copy link
Contributor

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, benchmark is running fine on TPU.

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joerunde

@njhill njhill merged commit e1b0048 into vllm-project:main Apr 16, 2025
62 checks passed
lionelvillard pushed a commit to lionelvillard/vllm that referenced this pull request Apr 17, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants