-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Improve error for structured output backend selection #16717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add warning that request-level structured output backend selection is not supported in V1 - Improve the error so that it's more clear which value is which Signed-off-by: Harry Mellor <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the message!
Who is the log message for though? The person setting the request-level backend is going to see the exception, either in a Python program using vllm as a library, or in the HTTP response from the API.
My thinking was:
|
Won't all of these cases see the exception (either as the exception, or the HTTP error response) ? |
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
I thought that if a user set the request structured output backend to the same as the engine structured output backend, they wouldn't see the error? edit: from offline discussion we decided that the warning only helps offline users and makes server logs super noisy when the problem doesn't concern the server admin. I've removed the warning. |
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
…6717) Signed-off-by: Harry Mellor <[email protected]>
…6717) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…6717) Signed-off-by: Harry Mellor <[email protected]>
…6717) Signed-off-by: Harry Mellor <[email protected]>
…6717) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…6717) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Mu Huai <[email protected]>
cc @russellb @DarkLight1337