-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add property-based testing for vLLM endpoints using an API defined by an OpenAPI 3.1 schema #16721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tarun Kumar <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Tarun Kumar <[email protected]>
Signed-off-by: Tarun Kumar <[email protected]>
Signed-off-by: Tarun Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to open GH issues regarding the failures when running this test locally so someone can pick them up and fix them.
Yes, that's the plan. I'll start logging the issues based on the testing I've done. Also, I think it would be beneficial to add this to the testing pipeline. If we agree on that, I can look into it as well. |
Sounds good to me! |
Signed-off-by: Tarun Kumar <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Head branch was pushed to by a user without write access
Please fix pre-commit |
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Done |
… an OpenAPI 3.1 schema (vllm-project#16721) Signed-off-by: Tarun Kumar <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]> Signed-off-by: Yang Wang <[email protected]>
… an OpenAPI 3.1 schema (vllm-project#16721) Signed-off-by: Tarun Kumar <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]>
… an OpenAPI 3.1 schema (vllm-project#16721) Signed-off-by: Tarun Kumar <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]>
… an OpenAPI 3.1 schema (vllm-project#16721) Signed-off-by: Tarun Kumar <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
… an OpenAPI 3.1 schema (vllm-project#16721) Signed-off-by: Tarun Kumar <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]> Signed-off-by: Mu Huai <[email protected]>
This script leverages the Schemathesis library to perform property-based testing on an API defined by an OpenAPI 3.1 schema. Integrated with pytest, it automates the testing process, ensuring the API adheres to its contract and identifying potential issues.
Note: Haven't added this test to the CI/CD workflow yet. Once everyone agrees, I can include it in a separate PR. Also, this test only covers stateless testing. If needed, I can create another PR for stateful testing, but that will require some additional work.
Logs from my local testing which Suggest that there needs to be work done on the api side :