-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Bugfix] Revert max_prompt_len validation for decoder-only models. #16741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: David Heineman <[email protected]>
Signed-off-by: David Heineman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
…llm-project#16741) Signed-off-by: David Heineman <[email protected]>
…llm-project#16741) Signed-off-by: David Heineman <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…llm-project#16741) Signed-off-by: David Heineman <[email protected]>
…llm-project#16741) Signed-off-by: David Heineman <[email protected]>
…llm-project#16741) Signed-off-by: David Heineman <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…llm-project#16741) Signed-off-by: David Heineman <[email protected]> Signed-off-by: Mu Huai <[email protected]>
A bugfix (#16156) improved input validation for multi-modal models.
However for decoder-only models it changed:
to
This change breaks inputs for decoder-only models that provide inputs equal to
max_prompt_len
, which is valid behavior. This breaks LLM eval frameworks like OLMES and the LM Eval harness. See:FIX #16445
This will revert this change to the original behavior (
len(prompt_ids) > max_prompt_len
). This fixes the v1 engine as well.