Skip to content

[V1][Structured Output] Minor modification to _validate_structured_output() #16748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

[V1][Structured Output] Minor modification to _validate_structured_output() #16748

merged 1 commit into from
Apr 18, 2025

Conversation

shen-shanshan
Copy link
Contributor

@shen-shanshan shen-shanshan commented Apr 17, 2025 •
edited by github-actions bot
Loading

The changes in this PR:

  1. Remove if judgement for engine_level_backend == "auto", because we have check supported_backends above.
  2. Remove redundant params.guided_decoding.backend = engine_level_backend, because we have set above. After the verification of params.guided_decoding.backend above, it must be engine_level_backend.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 17, 2025
@shen-shanshan shen-shanshan mentioned this pull request Apr 17, 2025
Closed
9 tasks
@shen-shanshan
Copy link
Contributor Author

@russellb Could you please have a look at this PR? I think this refactor can make the code cleaner haha. 😄

russellb
russellb approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@russellb russellb enabled auto-merge (squash) April 17, 2025 15:48
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 17, 2025
auto-merge was automatically disabled April 18, 2025 01:39

Head branch was pushed to by a user without write access

@DarkLight1337 DarkLight1337 merged commit 30ed81b into vllm-project:main Apr 18, 2025
43 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@shen-shanshan @yangw-dev
[V1][Structured Output] Minor modification to `_validate_structured_o…
5ec4b53 
…utput()` (vllm-project#16748)

Signed-off-by: shen-shanshan <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@shen-shanshan @dbyoung18
[V1][Structured Output] Minor modification to `_validate_structured_o…
c5db0de 
…utput()` (vllm-project#16748)

Signed-off-by: shen-shanshan <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@shen-shanshan @lk-chen
[V1][Structured Output] Minor modification to `_validate_structured_o…
2cf90d2 
…utput()` (vllm-project#16748)

Signed-off-by: shen-shanshan <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@shen-shanshan @adobrzyn
[V1][Structured Output] Minor modification to `_validate_structured_o…
fc52d9e 
…utput()` (vllm-project#16748)

Signed-off-by: shen-shanshan <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@shen-shanshan
[V1][Structured Output] Minor modification to `_validate_structured_o…
31c4365 
…utput()` (vllm-project#16748)

Signed-off-by: shen-shanshan <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shen-shanshan @russellb @DarkLight1337