Skip to content

[Misc] add collect_env to cli and docker image #16759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented Apr 17, 2025

FIX #16598

CLI command use:

$ python3 -m vllm.entrypoints.cli.main collect-env

@lengrongfu lengrongfu marked this pull request as ready for review April 17, 2025 06:17
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

DarkLight1337 commented Apr 17, 2025

Is it not possible to simply add collect_env.py to the image like the benchmarks?

@lengrongfu
Copy link
Contributor Author

Is it not possible to simply add collect_env.py to the image like the benchmarks?

Current add two type, a type is cli vllm collect-env , another type is python collect_env.py.

@lengrongfu lengrongfu force-pushed the feat/add_collect_env branch from b8e3595 to 9cf01bc Compare April 17, 2025 15:35
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 17, 2025 15:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 17, 2025
@vllm-bot vllm-bot merged commit 7bdfd29 into vllm-project:main Apr 18, 2025
66 of 74 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add collect_env.py file to vllm-workspace in docker image
3 participants