Skip to content

[Doc] Changed explanation of generation_tokens_total and prompt_tokens_total counter type metrics to avoid confusion #16784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

insukim1994
Copy link
Contributor

@insukim1994 insukim1994 commented Apr 17, 2025

FIX #16783 (link existing issues this PR will resolve)

…s_total counter type metrics to avoid confusion.

Signed-off-by: insukim1994 <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 17, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) April 17, 2025 13:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 17, 2025
@markmc
Copy link
Member

markmc commented Apr 17, 2025

Thanks. The typo originates from the Grafana dashboard. It would be great to fix it there too:

@markmc markmc added the v1 label Apr 17, 2025
@insukim1994
Copy link
Contributor Author

Thanks. The typo originates from the Grafana dashboard. It would be great to fix it there too:

Sure! I will also fix them too. Thanks for double checking!

@robertgshaw2-redhat robertgshaw2-redhat merged commit 7c02d6a into vllm-project:main Apr 17, 2025
40 of 42 checks passed
@insukim1994
Copy link
Contributor Author

insukim1994 commented Apr 17, 2025

I tried to add @markmc's suggestion and I noticed that the legends at Grafana are correct since it is wrapped by rate() function:

yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…s_total counter type metrics to avoid confusion (vllm-project#16784)

Signed-off-by: insukim1994 <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
…s_total counter type metrics to avoid confusion (vllm-project#16784)

Signed-off-by: insukim1994 <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
…s_total counter type metrics to avoid confusion (vllm-project#16784)

Signed-off-by: insukim1994 <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
…s_total counter type metrics to avoid confusion (vllm-project#16784)

Signed-off-by: insukim1994 <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…s_total counter type metrics to avoid confusion (vllm-project#16784)

Signed-off-by: insukim1994 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Proposing a minor change in "Metrics" documentation.
3 participants