-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Doc] Changed explanation of generation_tokens_total and prompt_tokens_total counter type metrics to avoid confusion #16784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s_total counter type metrics to avoid confusion. Signed-off-by: insukim1994 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Thanks. The typo originates from the Grafana dashboard. It would be great to fix it there too:
|
Sure! I will also fix them too. Thanks for double checking! |
7c02d6a
into
vllm-project:main
I tried to add @markmc's suggestion and I noticed that the legends at Grafana are correct since it is wrapped by
|
…s_total counter type metrics to avoid confusion (vllm-project#16784) Signed-off-by: insukim1994 <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…s_total counter type metrics to avoid confusion (vllm-project#16784) Signed-off-by: insukim1994 <[email protected]>
…s_total counter type metrics to avoid confusion (vllm-project#16784) Signed-off-by: insukim1994 <[email protected]>
…s_total counter type metrics to avoid confusion (vllm-project#16784) Signed-off-by: insukim1994 <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…s_total counter type metrics to avoid confusion (vllm-project#16784) Signed-off-by: insukim1994 <[email protected]> Signed-off-by: Mu Huai <[email protected]>
FIX #16783 (link existing issues this PR will resolve)