Skip to content

Add hardware print to TPU V1 test #16792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

Add hardware print to TPU V1 test #16792

merged 1 commit into from
Apr 18, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Apr 17, 2025

Adds tpu-info to get CI hardware information

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 17, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 17, 2025 16:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 17, 2025
yaochengji
yaochengji approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, Michael!

@vllm-bot vllm-bot merged commit 6a0f547 into main Apr 18, 2025
27 of 31 checks passed
@vllm-bot vllm-bot deleted the tpu-info-v1 branch April 18, 2025 05:13
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@mgoin @yangw-dev
Add hardware print to TPU V1 test (vllm-project#16792)
894ed0a 
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@mgoin @dbyoung18
Add hardware print to TPU V1 test (vllm-project#16792)
62aa711
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@mgoin @lk-chen
Add hardware print to TPU V1 test (vllm-project#16792)
a31ef00
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@mgoin @adobrzyn
Add hardware print to TPU V1 test (vllm-project#16792)
63c3069 
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@mgoin
Add hardware print to TPU V1 test (vllm-project#16792)
85e508d 
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaochengji yaochengji yaochengji approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgoin @yaochengji @DarkLight1337 @vllm-bot