Skip to content

[Misc] refactor examples series - Chat Completion Client With Tools #16829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

[Misc] refactor examples series - Chat Completion Client With Tools #16829

merged 1 commit into from
Apr 18, 2025

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Apr 18, 2025 •
edited by github-actions bot
Loading

…Tools

  • Continue to refactor example

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 18, 2025
@DarkLight1337 DarkLight1337 changed the title [Misc] refactor examples series - OpenAI Chat Completion Client With … [Misc] refactor examples series - Chat Completion Client With Tools Apr 18, 2025
@reidliu41 reidliu41 force-pushed the refactor-examples-series-08 branch from c6d0c46 to 88d0ac3 Compare April 18, 2025 21:36
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 18, 2025 22:29
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 18, 2025
@DarkLight1337 DarkLight1337 merged commit 5a5e29d into vllm-project:main Apr 18, 2025
39 of 41 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@reidliu41 @yangw-dev
[Misc] refactor examples series - Chat Completion Client With Tools (v…
2568055 
…llm-project#16829)

Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @dbyoung18
[Misc] refactor examples series - Chat Completion Client With Tools (v…
a330c2c 
…llm-project#16829)

Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @lk-chen
[Misc] refactor examples series - Chat Completion Client With Tools (v…
541e2fb 
…llm-project#16829)

Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@reidliu41 @adobrzyn
[Misc] refactor examples series - Chat Completion Client With Tools (v…
bafc9ac 
…llm-project#16829)

Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@reidliu41
[Misc] refactor examples series - Chat Completion Client With Tools (v…
157e13c 
…llm-project#16829)

Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reidliu41 @DarkLight1337