Skip to content

[Bugfix] Fix moe weight losing all extra attrs after process_weights_after_loading. #16854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2025
Merged

[Bugfix] Fix moe weight losing all extra attrs after process_weights_after_loading. #16854

merged 5 commits into from
Apr 28, 2025
+6 −11

Conversation

charlifu
Copy link
Contributor

@charlifu charlifu commented Apr 18, 2025 •
edited by github-actions bot
Loading

For #16842

Only set the Parameter.data field to retain the all extra attrs of weight.

@charlifu
fix moe padding
e20928a 
Signed-off-by: charlifu <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@charlifu charlifu mentioned this pull request Apr 18, 2025
Closed
1 task
@charlifu
linting
20a10cd 
Signed-off-by: charlifu <[email protected]>
@charlifu charlifu changed the title Fix moe weight losing all extra attrs after process_weights_after_loading. [Bugfix] Fix moe weight losing all extra attrs after process_weights_after_loading. Apr 18, 2025
@charlifu
Copy link
Contributor Author

add a small fix for not calling fp8 skinny gemm incorrectly.

@mgoin mgoin added bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed labels Apr 28, 2025
@mgoin mgoin enabled auto-merge (squash) April 28, 2025 17:20
@mgoin mgoin merged commit ed24620 into vllm-project:main Apr 28, 2025
49 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@charlifu @dbyoung18
[Bugfix] Fix moe weight losing all extra attrs after `process_weights…
13ecb40 
…_after_loading`. (vllm-project#16854)

Signed-off-by: charlifu <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@charlifu @lk-chen
[Bugfix] Fix moe weight losing all extra attrs after `process_weights…
f521611 
…_after_loading`. (vllm-project#16854)

Signed-off-by: charlifu <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@charlifu
[Bugfix] Fix moe weight losing all extra attrs after `process_weights…
bd05584 
…_after_loading`. (vllm-project#16854)

Signed-off-by: charlifu <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@charlifu
[Bugfix] Fix moe weight losing all extra attrs after `process_weights…
3868295 
…_after_loading`. (vllm-project#16854)

Signed-off-by: charlifu <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
@sarckk sarckk mentioned this pull request May 26, 2025
Closed
1 task
@charlifu charlifu deleted the charlifu/fix_moe_padding branch June 4, 2025 16:54
@SmiIemaker SmiIemaker mentioned this pull request Jun 11, 2025
Open
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@charlifu @minpeter
[Bugfix] Fix moe weight losing all extra attrs after `process_weights…
f3bd5ad 
…_after_loading`. (vllm-project#16854)

Signed-off-by: charlifu <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlifu @mgoin