Skip to content

[Kernel] Add expert_map support to Cutlass FP8 MOE #16861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2025
Merged

[Kernel] Add expert_map support to Cutlass FP8 MOE #16861

merged 5 commits into from
Apr 22, 2025

Conversation

varun-sundar-rabindranath
Copy link
Contributor

Add expert_map support to Cutlass FP8 MOE

varun sundar rabindranath added 3 commits April 18, 2025 16:37
support expert_map
88875be 
Signed-off-by: varun sundar rabindranath <[email protected]>
refactor and add ep tests
00583b7 
Signed-off-by: varun sundar rabindranath <[email protected]>
fixes
9f9562d 
Signed-off-by: varun sundar rabindranath <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@varun-sundar-rabindranath varun-sundar-rabindranath mentioned this pull request Apr 18, 2025
Open
bnellnm
bnellnm reviewed Apr 18, 2025
View reviewed changes
fix typing
3227481 
Signed-off-by: varun sundar rabindranath <[email protected]>
bnellnm
bnellnm reviewed Apr 18, 2025
View reviewed changes
bnellnm
bnellnm approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

refactor
00342e6 
Signed-off-by: varun sundar rabindranath <[email protected]>
tlrmchlsmth
tlrmchlsmth approved these changes Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 21, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) April 21, 2025 14:36
mgoin
mgoin approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and needs a force merge

@vllm-bot vllm-bot merged commit 7b8a2ab into vllm-project:main Apr 22, 2025
84 of 86 checks passed
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
@varun-sundar-rabindranath @frieda-huang
[Kernel] Add expert_map support to Cutlass FP8 MOE (vllm-project#16861)
1205d14 
Signed-off-by: varun sundar rabindranath <[email protected]>
Co-authored-by: varun sundar rabindranath <[email protected]>
Signed-off-by: Frieda (Jingying) Huang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@varun-sundar-rabindranath @dbyoung18
[Kernel] Add expert_map support to Cutlass FP8 MOE (vllm-project#16861)
fa978e5 
Signed-off-by: varun sundar rabindranath <[email protected]>
Co-authored-by: varun sundar rabindranath <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@varun-sundar-rabindranath @lk-chen
[Kernel] Add expert_map support to Cutlass FP8 MOE (vllm-project#16861)
4fe6701 
Signed-off-by: varun sundar rabindranath <[email protected]>
Co-authored-by: varun sundar rabindranath <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@varun-sundar-rabindranath @adobrzyn
[Kernel] Add expert_map support to Cutlass FP8 MOE (vllm-project#16861)
569f598 
Signed-off-by: varun sundar rabindranath <[email protected]>
Co-authored-by: varun sundar rabindranath <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@varun-sundar-rabindranath
[Kernel] Add expert_map support to Cutlass FP8 MOE (vllm-project#16861)
a18c3b4 
Signed-off-by: varun sundar rabindranath <[email protected]>
Co-authored-by: varun sundar rabindranath <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@varun-sundar-rabindranath @minpeter
[Kernel] Add expert_map support to Cutlass FP8 MOE (vllm-project#16861)
bad72d0 
Signed-off-by: varun sundar rabindranath <[email protected]>
Co-authored-by: varun sundar rabindranath <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@mgoin mgoin mgoin approved these changes

@bnellnm bnellnm bnellnm approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

Assignees
No one assigned
Labels
force-merge ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@varun-sundar-rabindranath @tlrmchlsmth @mgoin @bnellnm @vllm-bot