Skip to content

Serialize tensors using int8 views #16866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 19, 2025
Merged

Conversation

p88h
Copy link
Contributor

@p88h p88h commented Apr 18, 2025

Allows to support arbitrary types like bfloat16

Allows to support arbitrary types like bfloat16

Signed-off-by: Staszek Pasko <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Staszek Pasko <[email protected]>
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @p88h, looks great.

Could you also include the test changes from #16860?

p88h and others added 2 commits April 18, 2025 22:10
Co-authored-by: Nick Hill <[email protected]>
Signed-off-by: Staszek Pasko <[email protected]>
@p88h
Copy link
Contributor Author

p88h commented Apr 18, 2025

Thanks @p88h, looks great.

Could you also include the test changes from #16860?

Added, PTAL.

@p88h p88h requested a review from njhill April 18, 2025 20:12
Signed-off-by: Staszek Pasko <[email protected]>
Co-authored-by: Nick Hill <[email protected]>
Signed-off-by: Staszek Pasko <[email protected]>
@p88h p88h requested a review from njhill April 18, 2025 21:28
Co-authored-by: Nick Hill <[email protected]>
Signed-off-by: Staszek Pasko <[email protected]>
p88h added 2 commits April 18, 2025 23:56
Signed-off-by: Staszek Pasko <[email protected]>
Signed-off-by: Staszek Pasko <[email protected]>
@p88h p88h requested a review from njhill April 18, 2025 22:04
It's now separate from tensors

Signed-off-by: Staszek Pasko <[email protected]>
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 19, 2025
@njhill njhill merged commit 87aaade into vllm-project:main Apr 19, 2025
58 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
Signed-off-by: Staszek Pasko <[email protected]>
Co-authored-by: Nick Hill <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
Signed-off-by: Staszek Pasko <[email protected]>
Co-authored-by: Nick Hill <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
@p88h p88h deleted the serialize-tensors branch May 5, 2025 19:01
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Staszek Pasko <[email protected]>
Co-authored-by: Nick Hill <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants