-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[frontend] enhance tool_calls type check #16882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] enhance tool_calls type check #16882
Conversation
Signed-off-by: reidliu41 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
@DarkLight1337 could you pls also help to take a look this? |
Signed-off-by: reidliu41 <[email protected]>
Can you add a comment explaining that this is just for compatibility purposes? Since it's technically unnecessary if downstream compiles with OpenAI spec |
Signed-off-by: reidliu41 <[email protected]>
Signed-off-by: reidliu41 <[email protected]> Co-authored-by: reidliu41 <[email protected]> Signed-off-by: Frieda (Jingying) Huang <[email protected]>
Signed-off-by: reidliu41 <[email protected]> Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: reidliu41 <[email protected]> Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: reidliu41 <[email protected]> Co-authored-by: reidliu41 <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Signed-off-by: reidliu41 <[email protected]> Co-authored-by: reidliu41 <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Signed-off-by: reidliu41 <[email protected]> Co-authored-by: reidliu41 <[email protected]> Signed-off-by: minpeter <[email protected]>
FIX #16678 (link existing issues this PR will resolve)
Based on the description with tool_calls is None, it can reproduce: