-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Perf] Optimize _update_states
for GPU model runner
#16910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: snowcharm <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
_update_states
for GPU model runner in V1_update_states
for GPU model runner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find for sort, I wasn't aware of this difference
https://docs.python.org/3/howto/sorting.html#sorting-basics
You can also use the list.sort() method. It modifies the list in-place (and returns None to avoid confusion). Usually it’s less convenient than sorted() - but if you don’t need the original list, it’s slightly more efficient.
Signed-off-by: snowcharm <[email protected]>
…6910) Signed-off-by: snowcharm <[email protected]> Signed-off-by: Frieda (Jingying) Huang <[email protected]>
…6910) Signed-off-by: snowcharm <[email protected]>
…6910) Signed-off-by: snowcharm <[email protected]>
…6910) Signed-off-by: snowcharm <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…6910) Signed-off-by: snowcharm <[email protected]> Signed-off-by: Mu Huai <[email protected]>
…6910) Signed-off-by: snowcharm <[email protected]> Signed-off-by: minpeter <[email protected]>
This PR makes a small optimization for the
_update_states
method inv1/worker/gpu_model_runner.py
. The change slightly improves the performance while maintaining readability.