Skip to content

Add assertion for no objects while hashing hf_config #16930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

zou3519
Copy link
Collaborator

@zou3519 zou3519 commented Apr 21, 2025

We make the assumption that the hf_config is serializable. If there are any object ids in it, it will cause torch.compile to recompile every time the object id changes (which is always on warm start).

Test Plan:

  • ran python benchmark_latency.py (smoke test)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@zou3519 zou3519 marked this pull request as ready for review April 21, 2025 16:55
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 21, 2025
@DarkLight1337
Copy link
Member

The language models test is failing consistently, PTAL

We make the assumption that the hf_config is serializable. If there are
any object ids in it, it will cause torch.compile to recompile every
time the object id changes (which is always on warm start).

Test Plan:
- ran `python benchmark_latency.py` (smoke test)

Signed-off-by: rzou <[email protected]>
@zou3519 zou3519 force-pushed the hash_object_assertion branch from 7fa12db to 4a5d901 Compare April 22, 2025 12:41
@zou3519
Copy link
Collaborator Author

zou3519 commented Apr 22, 2025

The language models test is failing consistently, PTAL

It ended up being a false positive, I tightened the regex some more.

@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) April 22, 2025 12:49
@vllm-bot vllm-bot merged commit 7f58fb9 into vllm-project:main Apr 22, 2025
41 of 43 checks passed
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants