-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add assertion for no objects while hashing hf_config #16930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
The language models test is failing consistently, PTAL |
We make the assumption that the hf_config is serializable. If there are any object ids in it, it will cause torch.compile to recompile every time the object id changes (which is always on warm start). Test Plan: - ran `python benchmark_latency.py` (smoke test) Signed-off-by: rzou <[email protected]>
7fa12db
to
4a5d901
Compare
It ended up being a false positive, I tightened the regex some more. |
) Signed-off-by: rzou <[email protected]> Signed-off-by: Frieda (Jingying) Huang <[email protected]>
) Signed-off-by: rzou <[email protected]>
) Signed-off-by: rzou <[email protected]>
) Signed-off-by: rzou <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
) Signed-off-by: rzou <[email protected]> Signed-off-by: Mu Huai <[email protected]>
) Signed-off-by: rzou <[email protected]> Signed-off-by: minpeter <[email protected]>
We make the assumption that the hf_config is serializable. If there are any object ids in it, it will cause torch.compile to recompile every time the object id changes (which is always on warm start).
Test Plan:
python benchmark_latency.py
(smoke test)