Skip to content

[Misc] Change buckets of histogram_iteration_tokens to [1, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens #17033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sfc-gh-zhwang
Copy link
Contributor

@sfc-gh-zhwang sfc-gh-zhwang commented Apr 23, 2025

No description provided.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 23, 2025
@sfc-gh-zhwang sfc-gh-zhwang changed the title Change buckets of histogram_iteration_tokens to [1, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens [Misc] Change buckets of histogram_iteration_tokens to [1, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens Apr 23, 2025
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clean-up!

@youkaichao
Copy link
Member

initially I added it in #11031 to track batchsize distribution, but later we mainly use VLLM_LOG_BATCHSIZE_INTERVAL environment variable for this purpose.

@DarkLight1337
Copy link
Member

Please fix pre-commit

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 23, 2025
@sfc-gh-zhwang sfc-gh-zhwang force-pushed the zhwang/iteration-tokens branch 2 times, most recently from 6f622e1 to 0ea17aa Compare April 24, 2025 03:09
@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend structured-output tpu Related to Google TPUs labels Apr 24, 2025
Signed-off-by: sfc-gh-zhwang <[email protected]>
@sfc-gh-zhwang sfc-gh-zhwang force-pushed the zhwang/iteration-tokens branch from 0ea17aa to 77f1047 Compare April 24, 2025 03:23
@mergify mergify bot removed the tpu Related to Google TPUs label Apr 24, 2025
@DarkLight1337
Copy link
Member

Pre-commit is still failing, can you fix it?

@sfc-gh-zhwang
Copy link
Contributor Author

[2025-04-24T05:49:22Z] FAILED spec_decode/e2e/test_multistep_correctness.py::test_spec_decode_e2e_greedy_correctness_with_preemption[1-4-256-test_llm_kwargs1-baseline_llm_kwargs0-per_test_common_llm_kwargs0-common_llm_kwargs0] - AssertionError: function <function test_spec_decode_e2e_greedy_correctness_with_preemption at 0x7f4d58803880> failed when called with args () and kwargs {'vllm_runner': <class 'tests.conftest.VllmRunner'>, 'common_llm_kwargs': {'block_size': 8, 'num_gpu_blocks_override': 34, 'max_model_len': 272, 'enforce_eager': True}, 'per_test_common_llm_kwargs': {'model_name': 'JackFram/llama-160m'}, 'baseline_llm_kwargs': {}, 'test_llm_kwargs': {'speculative_config': {'model': 'JackFram/llama-68m', 'num_speculative_tokens': 5}, 'enable_chunked_prefill': True, 'max_num_batched_tokens': 4, 'max_num_seqs': 4}, 'batch_size': 4, 'output_len': 256, 'seed': 1}
--
  | [2025-04-24T05:49:22Z] FAILED spec_decode/e2e/test_multistep_correctness.py::test_spec_decode_different_block_size[1-32-2-test_llm_kwargs1-baseline_llm_kwargs0-per_test_common_llm_kwargs0-common_llm_kwargs0] - AssertionError: function <function test_spec_decode_different_block_size at 0x7f4d588039c0> failed when called with args () and kwargs {'vllm_runner': <class 'tests.conftest.VllmRunner'>, 'common_llm_kwargs': {'model_name': 'JackFram/llama-160m', 'enforce_eager': True}, 'per_test_common_llm_kwargs': {'block_size': 8}, 'baseline_llm_kwargs': {}, 'test_llm_kwargs': {'speculative_config': {'model': 'JackFram/llama-68m', 'num_speculative_tokens': 5}, 'enable_chunked_prefill': True, 'max_num_batched_tokens': 4, 'max_num_seqs': 4}, 'batch_size': 2, 'output_len': 32, 'seed': 1}


@DarkLight1337 i am curious why would this fail

@DarkLight1337
Copy link
Member

The spec decode failure is unrelated to the PR. I think you just need to fix pre-commit. Make sure you merge from main as well

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 27, 2025 10:20
@DarkLight1337 DarkLight1337 disabled auto-merge April 27, 2025 10:20
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 27, 2025 10:20
@DarkLight1337
Copy link
Member

I have fixed pre-commit for you

@DarkLight1337 DarkLight1337 merged commit 18445ed into vllm-project:main Apr 27, 2025
48 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033)

Signed-off-by: sfc-gh-zhwang <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033)

Signed-off-by: sfc-gh-zhwang <[email protected]>
@sfc-gh-zhwang
Copy link
Contributor Author

@DarkLight1337 sorry didn't get time, thank you so much

adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033)

Signed-off-by: sfc-gh-zhwang <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033)

Signed-off-by: sfc-gh-zhwang <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033)

Signed-off-by: sfc-gh-zhwang <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033)

Signed-off-by: sfc-gh-zhwang <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed structured-output v1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants