-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Misc] Change buckets of histogram_iteration_tokens to [1, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens #17033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the clean-up!
initially I added it in #11031 to track batchsize distribution, but later we mainly use |
Please fix pre-commit |
6f622e1
to
0ea17aa
Compare
Signed-off-by: sfc-gh-zhwang <[email protected]>
0ea17aa
to
77f1047
Compare
Pre-commit is still failing, can you fix it? |
@DarkLight1337 i am curious why would this fail |
The spec decode failure is unrelated to the PR. I think you just need to fix pre-commit. Make sure you merge from main as well |
Signed-off-by: DarkLight1337 <[email protected]>
I have fixed pre-commit for you |
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033) Signed-off-by: sfc-gh-zhwang <[email protected]>
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033) Signed-off-by: sfc-gh-zhwang <[email protected]>
@DarkLight1337 sorry didn't get time, thank you so much |
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033) Signed-off-by: sfc-gh-zhwang <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033) Signed-off-by: sfc-gh-zhwang <[email protected]> Signed-off-by: Mu Huai <[email protected]>
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033) Signed-off-by: sfc-gh-zhwang <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
… 64, 128, 256, 512, 1024, 2048, 4096, 8096] to represent number of tokens (vllm-project#17033) Signed-off-by: sfc-gh-zhwang <[email protected]> Signed-off-by: minpeter <[email protected]>
No description provided.