Skip to content

[MISC][AMD] Add unused annotation to rocm kernel file #17097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

[MISC][AMD] Add unused annotation to rocm kernel file #17097

merged 1 commit into from
Apr 26, 2025

Conversation

houseroad
Copy link
Collaborator

@houseroad houseroad commented Apr 24, 2025 •
edited by github-actions bot
Loading

Bf2 is not used, and at Meta we force the compiler flag, no unused var.

Need to tag it to make the compilation.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@WoosukKwon
Copy link
Collaborator

Just curious: Can we just delete the variable?

@houseroad
Copy link
Collaborator Author

houseroad commented Apr 24, 2025 •
edited
Loading

Yes, we can. I think it's better to add the same compiler flag to the AMD build. cc: @hongxiayang

hongxiayang
hongxiayang reviewed Apr 24, 2025
View reviewed changes
csrc/rocm/skinny_gemms.cu
@@ -150,7 +150,7 @@ __global__ void LLGemm1_kernel(const scalar_t* in_a, const scalar_t* in_b,
colB_elem4w = bf4[threadid * 4 + 3];

scalar2_t Af2;
scalar2_t Bf2;
[[maybe_unused]] scalar2_t Bf2;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad Good catch (thumb up to the tool which found this). It looks to me that it is safe to remove the unused variable.
@WoosukKwon vllm should enable this tool in the pre-commit check

csrc/rocm/skinny_gemms.cu
@@ -150,7 +150,7 @@ __global__ void LLGemm1_kernel(const scalar_t* in_a, const scalar_t* in_b,
colB_elem4w = bf4[threadid * 4 + 3];

scalar2_t Af2;
scalar2_t Bf2;
[[maybe_unused]] scalar2_t Bf2;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[[maybe_unused]] scalar2_t Bf2;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @charlifu

@hongxiayang
Copy link
Collaborator

Yes, we can. I think it's better to add the same compiler flag to the AMD build. cc: @hongxiayang

what is the flag?

@houseroad
Copy link
Collaborator Author

Something like unused-variable

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 26, 2025
@vllm-bot vllm-bot merged commit c8e5be3 into vllm-project:main Apr 26, 2025
87 of 90 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@houseroad @dbyoung18
[MISC][AMD] Add unused annotation to rocm kernel file (vllm-project#1…
df82b33 
…7097)

Signed-off-by: Lu Fang <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@houseroad @lk-chen
[MISC][AMD] Add unused annotation to rocm kernel file (vllm-project#1…
e41d602 
…7097)

Signed-off-by: Lu Fang <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@houseroad @adobrzyn
[MISC][AMD] Add unused annotation to rocm kernel file (vllm-project#1…
2e11088 
…7097)

Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@houseroad
[MISC][AMD] Add unused annotation to rocm kernel file (vllm-project#1…
c8a5db0 
…7097)

Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@houseroad
[MISC][AMD] Add unused annotation to rocm kernel file (vllm-project#1…
dbb8e84 
…7097)

Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@houseroad @minpeter
[MISC][AMD] Add unused annotation to rocm kernel file (vllm-project#1…
442bd6c 
…7097)

Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@hongxiayang hongxiayang hongxiayang approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@houseroad @WoosukKwon @hongxiayang @comaniac @vllm-bot