Skip to content

Update test_flash_attn.py #17102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

Update test_flash_attn.py #17102

merged 1 commit into from
Apr 26, 2025

Conversation

ShuaibinLi
Copy link
Contributor

@ShuaibinLi ShuaibinLi commented Apr 24, 2025 •
edited by github-actions bot
Loading

fix flash_attn_fp8 test

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ShuaibinLi
Update test_flash_attn.py
a164275 
fix flash_attn_fp8 test

Signed-off-by: ShuaibinLi <[email protected]>
LucasWilkinson
LucasWilkinson approved these changes Apr 26, 2025
View reviewed changes
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) April 26, 2025 20:45
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 26, 2025
@LucasWilkinson LucasWilkinson merged commit 9869453 into vllm-project:main Apr 26, 2025
41 of 42 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@ShuaibinLi @dbyoung18
Update test_flash_attn.py (vllm-project#17102)
c586155 
Signed-off-by: ShuaibinLi <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@ShuaibinLi @lk-chen
Update test_flash_attn.py (vllm-project#17102)
407e630 
Signed-off-by: ShuaibinLi <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@ShuaibinLi @adobrzyn
Update test_flash_attn.py (vllm-project#17102)
d2a0869 
Signed-off-by: ShuaibinLi <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@ShuaibinLi
Update test_flash_attn.py (vllm-project#17102)
f8d0820 
Signed-off-by: ShuaibinLi <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@ShuaibinLi
Update test_flash_attn.py (vllm-project#17102)
774c3c3 
Signed-off-by: ShuaibinLi <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@ShuaibinLi @minpeter
Update test_flash_attn.py (vllm-project#17102)
592778d 
Signed-off-by: ShuaibinLi <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWilkinson LucasWilkinson LucasWilkinson approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShuaibinLi @LucasWilkinson