-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Bugfix] gemma[2,3] interleaved attention when sliding window is disabled #17180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chen Zhang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Reference Slack discussion: https://vllm-dev.slack.com/archives/C07QCGVDNUF/p1744754229620969 |
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Confirmed this fix works for both v0 and v1 engine for following test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…bled (vllm-project#17180) Signed-off-by: Chen Zhang <[email protected]>
…bled (vllm-project#17180) Signed-off-by: Chen Zhang <[email protected]>
…bled (vllm-project#17180) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…bled (vllm-project#17180) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Mu Huai <[email protected]>
…bled (vllm-project#17180) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
…bled (vllm-project#17180) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: minpeter <[email protected]>
I get the following errors when running
VLLM_ATTENTION_BACKEND=FLASHINFER vllm serve google/gemma-2-2b-it
This PR fix it