-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Bugfix] Fix Lora Name Parsing #17196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Alex-Brooks <[email protected]>
e919ee9
to
001e63a
Compare
Thank you for your contribution, will look at this ASAP |
Co-authored-by: Jee Jee Li <[email protected]> Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
c4d61ef
to
5504775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, LGTM
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Jee Jee Li <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Jee Jee Li <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Jee Jee Li <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Jee Jee Li <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Jee Jee Li <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Co-authored-by: Jee Jee Li <[email protected]> Signed-off-by: minpeter <[email protected]>
Currently, we assume lora weights start with
base_model.model.
and split the prefix of lora weights accordingly. This is usually true, but in some situations, there may be lora adapters that don't have this prefix. An example of such a model is granite speech 3.3, where the audio specific lora weights are bundled directly with the model so that they can be automatically loaded together withfrom_pretrained
using the transformers peft mixin, and the weight names align with the transformers (not peft) model tensor names.This fix keeps the full prefix if the lora tensors don't start with
base_model.model.
. This is needed for #16246 to work correctly, since the lora is currently not applied due to erroneous slicing (e.g.,language_model.model.layers.1.self_attn_q_proj
vslayers.1.self_attn_q_proj
)