Skip to content

[Bugfix] Fix Lora Name Parsing #17196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 27, 2025

Conversation

alex-jw-brooks
Copy link
Contributor

@alex-jw-brooks alex-jw-brooks commented Apr 25, 2025

Currently, we assume lora weights start with base_model.model. and split the prefix of lora weights accordingly. This is usually true, but in some situations, there may be lora adapters that don't have this prefix. An example of such a model is granite speech 3.3, where the audio specific lora weights are bundled directly with the model so that they can be automatically loaded together with from_pretrained using the transformers peft mixin, and the weight names align with the transformers (not peft) model tensor names.

This fix keeps the full prefix if the lora tensors don't start with base_model.model.. This is needed for #16246 to work correctly, since the lora is currently not applied due to erroneous slicing (e.g., language_model.model.layers.1.self_attn_q_proj vs layers.1.self_attn_q_proj)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Alex-Brooks <[email protected]>
@jeejeelee
Copy link
Collaborator

Thank you for your contribution, will look at this ASAP

alex-jw-brooks and others added 2 commits April 27, 2025 09:04
Co-authored-by: Jee Jee Li <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, LGTM

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 27, 2025
@jeejeelee jeejeelee merged commit 756848e into vllm-project:main Apr 27, 2025
63 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
Signed-off-by: Alex-Brooks <[email protected]>
Co-authored-by: Jee Jee Li <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Alex-Brooks <[email protected]>
Co-authored-by: Jee Jee Li <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Alex-Brooks <[email protected]>
Co-authored-by: Jee Jee Li <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Signed-off-by: Alex-Brooks <[email protected]>
Co-authored-by: Jee Jee Li <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants