Skip to content

[Minor][Models] Fix Return Types of Llama & Eagle #17220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

[Minor][Models] Fix Return Types of Llama & Eagle #17220

merged 1 commit into from
Apr 26, 2025

Conversation

WoosukKwon
Copy link
Collaborator

Minor type fixes after #16937

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@vllm-bot vllm-bot merged commit b278911 into main Apr 26, 2025
17 of 22 checks passed
@vllm-bot vllm-bot deleted the fix-return-type branch April 26, 2025 04:54
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@WoosukKwon @dbyoung18
[Minor][Models] Fix Return Types of Llama & Eagle (vllm-project#17220)
6f64f82 
Signed-off-by: Woosuk Kwon <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@WoosukKwon @lk-chen
[Minor][Models] Fix Return Types of Llama & Eagle (vllm-project#17220)
f5a9aed 
Signed-off-by: Woosuk Kwon <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@WoosukKwon @adobrzyn
[Minor][Models] Fix Return Types of Llama & Eagle (vllm-project#17220)
592083e 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@WoosukKwon
[Minor][Models] Fix Return Types of Llama & Eagle (vllm-project#17220)
7998d8a 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@WoosukKwon
[Minor][Models] Fix Return Types of Llama & Eagle (vllm-project#17220)
52e3dc6 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@WoosukKwon @minpeter
[Minor][Models] Fix Return Types of Llama & Eagle (vllm-project#17220)
6873697 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WoosukKwon @DarkLight1337 @vllm-bot