Skip to content

Make name of compressed-tensors quant method consistent across vLLM #17255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 27, 2025

The compressed tensors quantization method was referred to as compressed-tensors and compressed_tensors in different places, they've now been standardised to compressed-tensors.

Issue was discovered in #17130.

Splitting the fix into this PR to reduce the review load on the original.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the tpu Related to Google TPUs label Apr 27, 2025
@mgoin
Copy link
Member

mgoin commented Apr 27, 2025

This was done for backcompat since some model configs use dash and others use underscore, so I would want to make sure both would still match

@hmellor
Copy link
Member Author

hmellor commented Apr 27, 2025

Ok, I'll add some post processing to coerce any hyphens to underscores, then after that point we can standardise on compressed_tensors inside vLLM.

Since we already call lower() to standardise the quant method string it shouldn't be controversial to call replace("-", "_") for the same reason.

@hmellor
Copy link
Member Author

hmellor commented Apr 27, 2025

The error in the fast check seems unrelated link:

[2025-04-27T14:09:03Z] ERROR 04-27 07:09:03 [serving_completion.py:116] ValueError: This model's maximum context length is 8192 tokens. However, you requested 10010 tokens (10000 in the messages, 10 in the completion). Please reduce the length of the messages or completion.

@mgoin
Copy link
Member

mgoin commented Apr 28, 2025

FWIW the standard is compressed-tensors if we want to convert to dash instead for it:

@hmellor hmellor changed the title Make name of compressed_tensors quant method consistent across vLLM Make name of compressed-tensors quant method consistent across vLLM Apr 28, 2025
@hmellor
Copy link
Member Author

hmellor commented Apr 28, 2025

Since compressed-tensors is more correct, I've switched to using that instead

@hmellor hmellor requested a review from mgoin April 28, 2025 09:10
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting this in a good state

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 28, 2025
@hmellor hmellor enabled auto-merge (squash) April 28, 2025 15:57
@hmellor hmellor merged commit b6dd32a into vllm-project:main Apr 28, 2025
65 checks passed
@hmellor hmellor deleted the consolidate-conpressed-tensors branch April 28, 2025 16:28
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quantization ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants