Skip to content

[doc] Add feature status legend #17257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2025
Merged

[doc] Add feature status legend #17257

merged 1 commit into from
Apr 27, 2025

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Apr 27, 2025 •
edited by github-actions bot
Loading

seems missed the description for the icon.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 27, 2025
DarkLight1337
DarkLight1337 reviewed Apr 27, 2025
View reviewed changes
docs/source/models/supported_models.md Outdated
Comment on lines 228 to 232
- ✅︎ indicates that the strategy (LoRA or PP) is supported for the model.

- 🚧 indicates that the strategy (LoRA or PP) is planned but not yet supported for the model.

- ⚠️ indicates that the strategy (LoRA or PP) is available but may have known issues or limitations.
Copy link
Member

@DarkLight1337 DarkLight1337 Apr 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is applicable to all models, and is not limited to LoRA or PP. I would call this "feature" instead of "strategy". Can you make the legend its own section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated, feel free to take a look

@reidliu41
add feature status legend
7ddd2ad 
Signed-off-by: reidliu41 <[email protected]>
@reidliu41 reidliu41 changed the title [doc] Add icon descriptions for LoRA/PP status [doc] Add feature status legend Apr 27, 2025
DarkLight1337
DarkLight1337 approved these changes Apr 27, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@vllm-bot vllm-bot merged commit d92879b into vllm-project:main Apr 27, 2025
20 of 22 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @dbyoung18
[doc] Add feature status legend (vllm-project#17257)
cd99332 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @lk-chen
[doc] Add feature status legend (vllm-project#17257)
75e917f 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@reidliu41 @adobrzyn
[doc] Add feature status legend (vllm-project#17257)
6d6f838 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@reidliu41
[doc] Add feature status legend (vllm-project#17257)
5200a3c 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@reidliu41
[doc] Add feature status legend (vllm-project#17257)
aa3b2c3 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@reidliu41 @minpeter
[doc] Add feature status legend (vllm-project#17257)
4f33f19 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reidliu41 @DarkLight1337 @vllm-bot