-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Bugfix] Fix missing ARG in Dockerfile for arm64 platforms #17261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: lkm-schulz <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
…ect#17261) Signed-off-by: lkm-schulz <[email protected]>
…ect#17261) Signed-off-by: lkm-schulz <[email protected]>
…ect#17261) Signed-off-by: lkm-schulz <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
…ect#17261) Signed-off-by: lkm-schulz <[email protected]> Signed-off-by: Mu Huai <[email protected]>
…ect#17261) Signed-off-by: lkm-schulz <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
…ect#17261) Signed-off-by: lkm-schulz <[email protected]> Signed-off-by: minpeter <[email protected]>
The target
vllm-openai-base
uses the$TARGETPLATFORM
variable to modify which version ofbitsandbytes
is installed based on the platform. However, the Dockerfile does not specifyARG TARGETPLATFORM
for this target. When using Podman, the environment variable is thus not set and the build fails forlinux/arm64
targets (e.g., GH200).I believe Docker does not exhibit the same issue as
ARG TARGETPLATFORM
is declared for the base target.